Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate attributes are missing on PositiveInt #2426

Open
marcovisserFurore opened this issue Mar 30, 2023 · 2 comments
Open

Validate attributes are missing on PositiveInt #2426

marcovisserFurore opened this issue Mar 30, 2023 · 2 comments
Assignees
@marcovisserFurore
Labels
enhancement

Comments

@marcovisserFurore
Copy link
Member

Do we not need validate attributes on PositiveInt? This would solve #2424.
@ewoutkramer
Copy link
Member

We probably should, but it would not fix #2424, because it will not change the behaviour of the constructor, only of the validator!

@marcovisserFurore marcovisserFurore self-assigned this May 3, 2023
@marcovisserFurore
Copy link
Member Author

I removed this from the sprint, because it does not solve the issue #2424, and it's located in a remote area of the SDK, which is hardly used. There are more important issues to pick up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcovisserFurore marcovisserFurore

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ewoutkramer @mmsmits @marcovisserFurore