Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some references are empty in the Snapshots. #1550

Closed
MatthijsvdWielen opened this issue Nov 19, 2020 · 3 comments
Closed

Some references are empty in the Snapshots. #1550

MatthijsvdWielen opened this issue Nov 19, 2020 · 3 comments
Assignees

Comments

@MatthijsvdWielen
Copy link

On Simplifier some references in the Snapshot are now empty. See for example: https://simplifier.net/nictizstu3-zib2017/nictiz.ihe.mhd.minimal.documentreference
In the code this looks like this:

 <element id="DocumentReference.authenticator">
      <path value="DocumentReference.authenticator" />
      <short value="Who/what authenticated the document" />
      <definition value="Which person or organization authenticates that this document is valid." />
      <comment value="Contained resource" />
      <min value="0" />
      <max value="1" />
      <base>
        <path value="DocumentReference.authenticator" />
        <min value="0" />
        <max value="1" />
      </base>
      <type>
        <code value="Reference" />
        <aggregation value="contained" />
      </type>

Could have to do with the profile is setting aggregation constrains in the type and this is not correctly picked up in the snapshot

<type>
                <code value="Reference" />
                <aggregation value="contained" />
            </type>
@marcovisserFurore
Copy link
Member

@MatthijsvdWielen : is this still an issue?

@MatthijsvdWielen
Copy link
Author

@marcovisserFurore , good question.

Looking at the profile https://simplifier.net/NictizSTU3-Zib2017/IHE.MHD.Minimal.DocumentReference/~xml .
I do not see the target profile specified in the differential for the elements DocumentReference.authenticator and DocumentReference.context.sourcePatientInfo.

These also do not have a target profile in the snapshot. Is this the intended behavior?

@mmsmits mmsmits self-assigned this Jul 4, 2024
@mmsmits
Copy link
Member

mmsmits commented Jul 4, 2024

This is expected behaviour, if you want to make constraints in a type you also have to copy the TargetProfiles list.
Otherwise, the snapshot generator thinks you want to make the constraint of not allowing certain types (or all types).
The only solution to that is always repeat the targetProfile list when contraining an element type.

@mmsmits mmsmits closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants