Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Die, if Read 1 and Read 2 have different number of reads #219

Closed
FelixKrueger opened this issue Dec 14, 2018 · 2 comments
Closed

Die, if Read 1 and Read 2 have different number of reads #219

FelixKrueger opened this issue Dec 14, 2018 · 2 comments

Comments

@FelixKrueger
Copy link
Owner

This can be either a result of file truncation, or simply that R1 and R2 were specified incorrectly (e.g. one trimmed and one untrimmed file).

@FelixKrueger
Copy link
Owner Author

Added a check for the number of reads in R1 and R2. This is implemented once the in-silico bisulfite transformation of reads has completed.

Until now, e.g. Bowtie2 would crash mid way, but this is hard to spot:

Error, fewer reads in file specified with -2 than in file specified with -1
terminate called after throwing an instance of 'int'
(ERR): bowtie2-align died with signal 6 (ABRT) 

Now Bismark terminates with a [FATAL ERROR] before the alignment process is started, this should save a lot of headaches. Fixed in 1ff5cd4.

@FelixKrueger
Copy link
Owner Author

Just to add, this works in directional, --pbat and --non_directional mode for FastQ files only. Furthermore, it works for paired-end mode with Bowtie 2, and Bowtie 1 as long as the temporary files are not to be written out in a compressed form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant