Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileInpuStream created but not closed if an error occur. #29

Closed
willome opened this issue Jul 20, 2017 · 2 comments
Closed

FileInpuStream created but not closed if an error occur. #29

willome opened this issue Jul 20, 2017 · 2 comments

Comments

@willome
Copy link

willome commented Jul 20, 2017

  • Jackson-dataformat-csv version 2.8.8

When using csvMapper.readValues(file), a new FileinputStream is created, but if an error occur during the parsing, this inputStream is never closed.

@cowtowncoder
Copy link
Member

There is nothing specific in csv module here, so I assume this would be general problem.

Looks like readValue() variants should handle closing, but the readValues(...) is more complicated thing, returning MappingIterator. Challenge here is that there are many more code paths to keep track of, and it is not possible to use auto-closing (given that individual reads are not to close the parser).

So... could you please re-file at databind, for the general case, referring this issue?

@willome
Copy link
Author

willome commented Aug 21, 2017

Opened on databind : FasterXML/jackson-databind#1743

@willome willome closed this as completed Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants