Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continue to get empty tibbles for ESPN & Yahoo projections. #112

Open
BeardedJayhawk opened this issue Sep 1, 2021 · 3 comments
Open

continue to get empty tibbles for ESPN & Yahoo projections. #112

BeardedJayhawk opened this issue Sep 1, 2021 · 3 comments

Comments

@BeardedJayhawk
Copy link

when running scrape_data(), including ESPN & Yahoo in the sources produces no data, and does not generate an error.

@atungate
Copy link
Collaborator

atungate commented Sep 1, 2021

Hey BeardedJayhawk, Yahoo no longer published projections (they link-to fantasypros) and we do not have the ESPN ones working yet. We were in the process over the summer but had to shift priorities. We hope to have them up during the season at some point. Sorry about that! At some point in the future we are going to bump the package to v3.0 and we'll update the vignettes etc. (and remove Yahoo). Let me know if you have additional questions!

@jonathanjkent
Copy link

It seems that FleaFlicker is just using the FantasyPros average too. I don't know if that merits removing them as a source or including a warning or something. Just thought I would flag, after seeing this issue.

@atungate
Copy link
Collaborator

atungate commented Sep 7, 2021

@jonathanjkent, noticed that as well once the fantasypros weekly scrapes were fixed. Odd because fleaflicker has no mention of it on their site (whereas Yahoo just links to fantasypros). We are keeping them for now but will consider addressing the shared positions assuming the exact match continues (i.e., fleaflicker has individual defensive players but fantasypros only has DST for defense). Thanks for flagging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants