Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pullPolicyNotAlways shouldn't trigger if the image is pinned by digest #1058

Closed
chgl opened this issue Jul 6, 2024 · 0 comments
Closed

pullPolicyNotAlways shouldn't trigger if the image is pinned by digest #1058

chgl opened this issue Jul 6, 2024 · 0 comments
Labels
enhancement Adding additional functionality or improvements stale Marked as stale by stalebot triage This bug needs triage

Comments

@chgl
Copy link

chgl commented Jul 6, 2024

Is your feature request related to a problem? Please describe.

The pullPolicyNotAlways triggers whenever imagePullPolicy != "Always". However, if an image is already specified by its digest the danges described in https://polaris.docs.fairwinds.com/checks/reliability/#image-pull-policy don't apply.

Describe the solution you'd like

If an image is specified by its digest, then the pullPolicyNotAlways shouldn't apply.

E.g. a container spec with

image: "docker.io/curlimages/curl:8.8.0@sha256:73e4d532ea62d7505c5865b517d3704966ffe916609bedc22af6833dc9969bcd"
imagePullPolicy: IfNotPresent

should not cause the check to fail.

Describe alternatives you've considered

Additional context

@chgl chgl added enhancement Adding additional functionality or improvements triage This bug needs triage labels Jul 6, 2024
@github-actions github-actions bot added the stale Marked as stale by stalebot label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements stale Marked as stale by stalebot triage This bug needs triage
Projects
None yet
Development

No branches or pull requests

1 participant