-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check results of your module #48
Comments
Hi, the automatic recommendations are awesome, will change all the typos and some best practices. node-fetch is difficult as some people are running really old node versions and it just breaks their mm2 install. About the screenshot it would be nice to have a About the page, in mobile the card are smaller than the screen width, some icons are not shown. In desktop I would have a max width for the card container, as if the screen is too big it would just expand. |
Thanks for the positive feedback! 😃
You can of course stay with node-fetch for as long as you like. From my point of view, people should update their system from time to time, even if it is inconvenient.
Good idea! There is already a similar plan. The idea is to extend the package.json with an MM section. But that's not my focus at the moment. If you now want a different image for your module, add "screenshot" or "example" anywhere in the file name.
I don't understand what you mean by that, sorry. Can you describe this in more detail?
I'm not so skilled when it comes to CSS. If you feel like it, please create a PR or write me what I could do better with the CSS. And if you have other ideas, like about new automatic recommendations, let me know! |
I just created an issue about the CSS: KristjanESPERANTO/MagicMirror-3rd-Party-Modules#6 🙂 |
I will look at it, maybe if I have some time I can send you a PR! |
That would be great! I've already made a few CSS changes, but there's definitely still a lot of room for improvement. |
Thanks for this nice modul! 😃
I am working on a new module list and analyzing all the modules that are on the official list and collecting a few notes on what could perhaps be adapted. You can find them here. Maybe you would like to tackle a few of them. I would be happy to receive feedback.
The text was updated successfully, but these errors were encountered: