specsuite: Fix some regressions

Lately we've made some changes that have affected the behavior of the
specsuite tests, causing them to fail. Much of this was caused by changes
to the harness itself (based on hcldec), although one break in particular
here was an intentional change to the implementation of modulo in
upstream cty to make it produce a more accurate result when used with
a fractional divisor.

cmd/hclspecsuite/runner.go

@@ -11,6 +11,7 @@ import (
  "sort"
  "strings"
 
+ "github.com/zclconf/go-cty-debug/ctydebug"
  "github.com/zclconf/go-cty/cty"
  "github.com/zclconf/go-cty/cty/convert"
  ctyjson "github.com/zclconf/go-cty/cty/json"
@@ -226,8 +227,9 @@ func (r *Runner) runTestInput(specFilename, inputFilename string, tf *TestFile)
  Severity: hcl.DiagError,
  Summary: "Incorrect result value",
  Detail: fmt.Sprintf(
- "Input file %s produced %#v, but was expecting %#v.",
+ "Input file %s produced %#v, but was expecting %#v.\n\n%s",
  inputFilename, val, tf.Result,
+ ctydebug.DiffValues(tf.Result, val),
  ),
  })
  }

go.mod

@@ -5,8 +5,6 @@ go 1.12
 require (
  github.com/agext/levenshtein v1.2.1
  github.com/apparentlymart/go-dump v0.0.0-20180507223929-23540a00eaa3
- github.com/apparentlymart/go-textseg v1.0.0 // indirect
- github.com/apparentlymart/go-textseg/v12 v12.0.0 // indirect
  github.com/apparentlymart/go-textseg/v13 v13.0.0
  github.com/davecgh/go-spew v1.1.1
  github.com/go-test/deep v1.0.3
@@ -18,10 +16,8 @@ require (
  github.com/sergi/go-diff v1.0.0
  github.com/spf13/pflag v1.0.2
  github.com/stretchr/testify v1.2.2 // indirect
- github.com/vmihailenco/msgpack v3.3.3+incompatible // indirect
  github.com/zclconf/go-cty v1.8.0
+ github.com/zclconf/go-cty-debug v0.0.0-20191215020915-b22d67c1ba0b
  golang.org/x/crypto v0.0.0-20190426145343-a29dc8fdc734
- golang.org/x/sync v0.0.0-20180314180146-1d60e4601c6f // indirect
  golang.org/x/sys v0.0.0-20190502175342-a43fa875dd82 // indirect
- golang.org/x/text v0.3.5 // indirect
 )

go.sum

@@ -4,8 +4,6 @@ github.com/apparentlymart/go-dump v0.0.0-20180507223929-23540a00eaa3 h1:ZSTrOEhi
 github.com/apparentlymart/go-dump v0.0.0-20180507223929-23540a00eaa3/go.mod h1:oL81AME2rN47vu18xqj1S1jPIPuN7afo62yKTNn3XMM=
 github.com/apparentlymart/go-textseg v1.0.0 h1:rRmlIsPEEhUTIKQb7T++Nz/A5Q6C9IuX2wFoYVvnCs0=
 github.com/apparentlymart/go-textseg v1.0.0/go.mod h1:z96Txxhf3xSFMPmb5X/1W05FF/Nj9VFpLOpjS5yuumk=
-github.com/apparentlymart/go-textseg/v12 v12.0.0 h1:bNEQyAGak9tojivJNkoqWErVCQbjdL7GzRt3F8NvfJ0=
-github.com/apparentlymart/go-textseg/v12 v12.0.0/go.mod h1:S/4uRK2UtaQttw1GenVJEynmyUenKwP++x/+DdGV/Ec=
 github.com/apparentlymart/go-textseg/v13 v13.0.0 h1:Y+KvPE1NYz0xl601PVImeQfFyEy6iT90AvPUL1NNfNw=
 github.com/apparentlymart/go-textseg/v13 v13.0.0/go.mod h1:ZK2fH7c4NqDTLtiYLvIkEghdlcqw7yxLeM89kiTRPUo=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
@@ -37,10 +35,11 @@ github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXf
 github.com/vmihailenco/msgpack v3.3.3+incompatible/go.mod h1:fy3FlTQTDXWkZ7Bh6AcGMlsjHatGryHQYUTf1ShIgkk=
 github.com/vmihailenco/msgpack/v4 v4.3.12/go.mod h1:gborTTJjAo/GWTqqRjrLCn9pgNN+NXzzngzBKDPIqw4=
 github.com/vmihailenco/tagparser v0.1.1/go.mod h1:OeAg3pn3UbLjkWt+rN9oFYB6u/cQgqMEUPoW2WPyhdI=
-github.com/zclconf/go-cty v1.2.0 h1:sPHsy7ADcIZQP3vILvTjrh74ZA175TFP5vqiNK1UmlI=
 github.com/zclconf/go-cty v1.2.0/go.mod h1:hOPWgoHbaTUnI5k4D2ld+GRpFJSCe6bCM7m1q/N4PQ8=
 github.com/zclconf/go-cty v1.8.0 h1:s4AvqaeQzJIu3ndv4gVIhplVD0krU+bgrcLSVUnaWuA=
 github.com/zclconf/go-cty v1.8.0/go.mod h1:vVKLxnk3puL4qRAv72AO+W99LUD4da90g3uUAzyuvAk=
+github.com/zclconf/go-cty-debug v0.0.0-20191215020915-b22d67c1ba0b h1:FosyBZYxY34Wul7O/MSKey3txpPYyCqVO5ZyceuQJEI=
+github.com/zclconf/go-cty-debug v0.0.0-20191215020915-b22d67c1ba0b/go.mod h1:ZRKQfBXbGkpdV6QMzT3rU1kSTAnfu1dO8dPKjYprgj8=
 golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
 golang.org/x/crypto v0.0.0-20190426145343-a29dc8fdc734 h1:p/H982KKEjUnLJkM3tt/LemDnOc1GiZL5FCVlORJ5zo=
 golang.org/x/crypto v0.0.0-20190426145343-a29dc8fdc734/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
@@ -53,14 +52,11 @@ golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5h
 golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20190502175342-a43fa875dd82 h1:vsphBvatvfbhlb4PO1BYSr9dzugGxJ/SQHoNufZJq1w=
 golang.org/x/sys v0.0.0-20190502175342-a43fa875dd82/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
-golang.org/x/text v0.3.0 h1:g61tztE5qeGQ89tm6NTjjM9VPIm088od1l6aSorWRWg=
 golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
-golang.org/x/text v0.3.2 h1:tW2bmiBqwgJj/UpqtC8EpXEZVYOwU0yG4iWbprSVAcs=
 golang.org/x/text v0.3.2/go.mod h1:bEr9sfX3Q8Zfm5fL9x+3itogRgK3+ptLWKqgva+5dAk=
 golang.org/x/text v0.3.5 h1:i6eZZ+zk0SOf0xgBpEpPD18qWcJda6q1sxt3S0kzyUQ=
 golang.org/x/text v0.3.5/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
 golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
 google.golang.org/appengine v1.1.0/go.mod h1:EbEs0AVv82hx2wNQdGPgUI5lhzA/G0D9YwlJXL52JkM=
 google.golang.org/appengine v1.6.5/go.mod h1:8WjMMxjGQR8xUklV/ARdw2HLXBOI7O7uCIDZVag1xfc=
-gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127 h1:qIbj1fsPNlZgppZ+VLlY7N33q108Sa+fhmuc+sWQYwY=
 gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=

specsuite/tests/expressions/operators.hcldec

@@ -3,19 +3,19 @@ object {
  labels = ["operator"]
 
  object {
- attr "exactly" { type = any }
- attr "not" { type = any }
- attr "type_mismatch_number" { type = any }
- attr "type_mismatch_bool" { type = any }
+ attr "exactly" { type = bool }
+ attr "not" { type = bool }
+ attr "type_mismatch_number" { type = bool }
+ attr "type_mismatch_bool" { type = bool }
  }
  }
  block_map "inequality" {
  labels = ["operator"]
 
  object {
- attr "lt" { type = any }
- attr "gt" { type = any }
- attr "eq" { type = any }
+ attr "lt" { type = bool }
+ attr "gt" { type = bool }
+ attr "eq" { type = bool }
  }
  }
  block "arithmetic" {
@@ -34,18 +34,18 @@ object {
  labels = ["operator"]
 
  object {
- attr "tt" { type = any }
- attr "ft" { type = any }
- attr "tf" { type = any }
- attr "ff" { type = any }
+ attr "tt" { type = bool }
+ attr "ft" { type = bool }
+ attr "tf" { type = bool }
+ attr "ff" { type = bool }
  }
  }
  block_map "logical_unary" {
  labels = ["operator"]
 
  object {
- attr "t" { type = any }
- attr "f" { type = any }
+ attr "t" { type = bool }
+ attr "f" { type = bool }
  }
  }
  block "conditional" {

specsuite/tests/expressions/operators.t

@@ -43,7 +43,7 @@ result = {
  mul = 9
  div = 0.1
  mod = 1
- mod_frac = 0.8000000000000000002
+ mod_frac = 0.80000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024
  }
  logical_binary = {
  "&&" = {