Unnecessary aliases for FHIR resources

[markkramerus]

GoFSH is defining unnecessary* aliases for base FHIR resources, e.g.:

Alias: $Identifier = https://hl7.org/fhir/StructureDefinition/Identifier
Alias: $Composition = https://hl7.org/fhir/StructureDefinition/Composition
Alias: $Endpoint = https://hl7.org/fhir/StructureDefinition/Endpoint
Alias: $HealthcareService = https://hl7.org/fhir/StructureDefinition/HealthcareService
Alias: $Observation = https://hl7.org/fhir/StructureDefinition/Observation
Alias: $PractitionerRole = https://hl7.org/fhir/StructureDefinition/PractitionerRole

One complicating factor is that this IG defines a profile named "Composition" that is based on Composition (really horrible style), so maybe this is necessary??

afourquet/us-odh@40c7487

[mint-thompson]

Unfortunately, I think these aliases are necessary. I verified that each of these aliases corresponds to a FHIR resource that shares a name with a resource defined in the IG:

• Identifier: input/resources/structuredefinition/obf-datatype-Identifier-extension.json
• Composition: input/resources/structuredefinition/obf-Composition.json
• Endpoint: input/resources/structuredefinition/obf-Endpoint.json
• HealthcareService: input/resources/structuredefinition/obf-HealthcareService.json
• Observation: input/resources/structuredefinition/obf-Observation.json
• PractitionerRole: input/resources/structuredefinition/obf-PractitionerRole.json

This behavior is expected based on the test case that asserts GoFSH should not resolve a URL to the name of a core FHIR resource if it shares a name with a local StructureDefinition.