Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EE 7.3 Strict type check change caused single variable file names to not work #3507

Open
litzinger opened this issue Jun 12, 2023 · 3 comments

Comments

@litzinger
Copy link
Contributor

Description of the problem

Compare these two changes:
https://github.com/ExpressionEngine/ExpressionEngine/blame/745f21f2bbac9d8fb013432e13023e0501f4eb6b/system/ee/ExpressionEngine/Addons/file/ft.file.php#L610

https://github.com/ExpressionEngine/ExpressionEngine/blame/bf3e6bdd291bccddfc7d6db396e81165f49ce2c0/system/ee/ExpressionEngine/Addons/file/ft.file.php#L628

The change to $tagdata === false means that the following tags do not render. At least in a Bloqs field the only way to get images with modifiers to render is to use the full tag pair, e.g.

This returns blank
<img src="{file_bloq:file:resize width='100' height='100'}" />

But if I used the full tag pair, or change the conditional back to falsey like in version 7.2.x it works.

{file_bloq:file:resize width='100' height='100'}
    {url}
{/file_bloq:file:resize}

Again this is using Bloqs, but I believe the same thing will happen in Grid (haven't had time to test it)

Environment Details:

  • Version: 7.3
@intoeetive
Copy link
Contributor

I've not been able to replicate this with Bloqs 5.0.10 and EE 7.3.3

@litzinger
Copy link
Contributor Author

Just following up b/c this seems to keep coming up with customers, but this was resolved in Bloqs 5.0.11. Yuri, I think I gave you a pre-5.0.11 build still numbered as 5.0.10.

@dougblackjr
Copy link
Contributor

@intoeetive I am having this issue as well. It's feeling like certain files are not getting all variables attached to it (i.e. some Files have :server_path, some do not).

@intoeetive intoeetive reopened this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants