Custom menu permissions in CP only look at primary role

[robinsowell]

I made a custom menu and set permissions so only superadmins have access.

I assigned a member to primary role of 'Editor' and then in role assignment, they're assigned to both Editor and Superadmin roles.

If I login as this member in the CP, I don't see my custom menu, even though they have superadmin as a secondary role.

Replicated EE 7.2.14

[intoeetive]

@robinsowell IDK if we should call it a bug, with the way how custom menus work now

If you create two menus, and try to assign them to same role, you'll see no error, but the assigment for the "older" one will be erased. And only one menu will be displayed.

So it looks like the custom menus are built with the idea that only one menu can be displayed at a time. And that menu is the one that's for primary role.

We might want to rework this - like, display each menu separately in the sidebar, with the menu name instead of "custom". But we probably will want to discuss this with @TomJaeger

[intoeetive]

Related discussion: #3572