Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #2695 to allow parsing of username tag in forgotten password email instructions template #2696

Draft
wants to merge 1 commit into
base: 7.dev
Choose a base branch
from

Conversation

jHards
Copy link
Contributor

@jHards jHards commented Jan 5, 2023

Overview

Fixes a parsing error in a user defined forgotten password email template. Proposed solution mirrors the approach for the forgotten username email.

Resolves #2695.

Nature of This Change

  • πŸ› Fixes a bug
  • πŸš€ Implements a new feature
  • πŸ› Refactors existing code
  • πŸ’… Fixes coding style
  • βœ… Adds tests
  • πŸ‘½ Adds new dependency
  • πŸ”₯ Removes unused files / code
  • πŸ”’ Improves security

Is this backwards compatible?

  • Yes
  • No

Documentation

N/A

Mirror forgotten username parsing method
@jHards jHards marked this pull request as draft January 5, 2023 05:03
@jHards
Copy link
Contributor Author

jHards commented Jan 5, 2023

@intoeetive - I've moved this back to draft as the current fix isn't fully backward compatible as the template was previously parsed by the template engine (which replaced {username} with a blank because no-one is logged in if you are resetting a password). I propose running through the template engine after we have made the local replacements to preserve anyone using other global variables etc - maybe after line 827 here. Is there an existing function we could use to achieve this?

Opportunity to use same method for the forgotten username template too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forgot Password Form email template parsing error
1 participant