Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Setting value for minY to -1 stops ore from spawning, even when maxY is not -1 #79

Open
Goldenlion5648 opened this issue Jul 21, 2022 · 1 comment
Assignees
Labels
Bug Bug or issue

Comments

@Goldenlion5648
Copy link

Minecraft Version

1.18.2

Forge Version

40.1.30

Mod Version

OreTweaker-1.18.2-3.3.0.jar

Describe the bug

Setting minY to -1 makes ore not spawn (even when maxY is greater than -1). I think the ore should only be disabled when both values are -1.

How to reproduce

set minY to -1, and maxY to a value such as 9 for an ore. Ore does not spawn as a result

Screenshots / Images

The ore in this case is lava replacing grass blocks
minY at -1
minY at -1

minY at 0
minY at 0

@Goldenlion5648 Goldenlion5648 changed the title [Bug] Relevant title here [Bug] Setting value for minY to -1 stops ore from spawn, even when maxY is not -1 Jul 21, 2022
@Goldenlion5648 Goldenlion5648 changed the title [Bug] Setting value for minY to -1 stops ore from spawn, even when maxY is not -1 [Bug] Setting value for minY to -1 stops ore from spawning, even when maxY is not -1 Jul 21, 2022
@EwyBoy
Copy link
Owner

EwyBoy commented Jul 21, 2022

You are right, there has probably been an oversight in the code when porting to 1.17 when the worlds expanded to go below 0. I think the old value for disabling ores where to set the values to -1.

Thank you for the detailed bug report.

@EwyBoy EwyBoy added the Bug Bug or issue label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or issue
Projects
None yet
Development

No branches or pull requests

2 participants