Fix binary file reading in bin_to_coe.py #761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
@XhovaniM8 we have some issues with our CLA checker. Your fix requires some minor mods, but we'll handle that and merge your PR fairly soon. Many thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have made the necessary changes to the bin_to_coe.py script to fix the issue of reading the binary file without the 'rb' flag, which caused decoding errors. This change ensures that the COE file is generated correctly from the binary file.
Related Issue
Fixes #760
Which devices/areas does this affect?
This affects the X300 series USRP devices. The change specifically impacts the process of generating COE files from binary files during firmware builds.
Testing Done
I have run the modified script in the provided docker environment and confirmed that the COE file is generated successfully without any errors. The testing was done in a controlled environment using the Ubuntu 22.04 docker image as described in the issue. All previous tests passed successfully after the modification.
Checklist
MPM compat, noc_shell, specific RFNoC block, ...)