Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make blog images responsive #790

Merged
merged 2 commits into from
Mar 7, 2023
Merged

make blog images responsive #790

merged 2 commits into from
Mar 7, 2023

Conversation

jaasonw
Copy link
Contributor

@jaasonw jaasonw commented Mar 7, 2023

fix #789

@netlify
Copy link

netlify bot commented Mar 7, 2023 •
edited
Loading

✅ Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit 4251472
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/64069a9d1fc68500087bc3ac
😎 Deploy Preview https://deploy-preview-790--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jaasonw
Copy link
Contributor Author

jaasonw commented Mar 7, 2023 •
edited
Loading

these arent gonna show in the preview i had to inspect element this in but im p sure it works

image

image

@jaasonw jaasonw enabled auto-merge (squash) March 7, 2023 01:55
@charliettaylor
Copy link
Contributor 

:global(img) {
  max-width: 100%;
  max-height: 100%;
  object-fit: contain;
}

is it worth it to add object-fit for fun or does it not do anything? I was running this on local and it seemed to be working too

@jaasonw
Copy link
Contributor Author

jaasonw commented Mar 7, 2023

fun has been added

@jaasonw
Copy link
Contributor Author

jaasonw commented Mar 7, 2023

i dont think it does anything though, so maybe just keep it simple?

stephaniePocci
stephaniePocci approved these changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@stephaniePocci stephaniePocci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pog, tysm!

@jaasonw jaasonw merged commit 63aec08 into main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephaniePocci stephaniePocci stephaniePocci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image overflow on the blogs
3 participants
@jaasonw @charliettaylor @stephaniePocci