Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribution for L.esri.Vector.vectorTileLayer #143

Open
gavinr opened this issue Aug 16, 2022 · 0 comments
Open

Attribution for L.esri.Vector.vectorTileLayer #143

gavinr opened this issue Aug 16, 2022 · 0 comments

Comments

@gavinr
Copy link
Contributor

gavinr commented Aug 16, 2022

Describe the bug

In #133/#135 we fixed the attribution for L.esri.Vector.vectorBasemapLayer(..) when an ID is passed. For example:

L.esri.Vector.vectorBasemapLayer("3e1a00aeae81496587988075fe529f71", ...);

We should have also fixed the case for L.esri.Vector.vectorTileLayer(..) when an ID is passed. For example:

L.esri.Vector.vectorTileLayer("3e1a00aeae81496587988075fe529f71", ...);

See the 5th example here:
image

https://codepen.io/gavinr/pen/ExEOdwd?editors=0010

Reproduction

https://codepen.io/gavinr/pen/ExEOdwd?editors=0010

  • Expected: the 5th example should contain the "Powered by Esri" attribution.
  • Actual: the 5th example does not contain the "Powered by Esri" attribution.

Logs

No response

System Info

Esri Leaflet Vector version: `v3.1.4`.

Additional Information

Originally logged in #142 - thank you @ItaiEinhorn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant