Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnDownloadedCallback call before file write done #36

Closed
BoneTM opened this issue Feb 2, 2021 · 2 comments
Closed

OnDownloadedCallback call before file write done #36

BoneTM opened this issue Feb 2, 2021 · 2 comments

Comments

@BoneTM
Copy link

BoneTM commented Feb 2, 2021

get empty file in the callback.
file is actually downloaded, if i create a timer to get the file later would be ok.
i think this callback should be after file write, right?

@BoneTM BoneTM changed the title OnDownloadedCallback OnDownloadedCallback call before file write done Feb 2, 2021
@ErikMinekus
Copy link
Owner

ErikMinekus commented Feb 2, 2021

You're right, I think the file is currently written after the callback is fired, I will change it so it writes the file before firing the callback.

@BoneTM
Copy link
Author

BoneTM commented Feb 2, 2021

You're right, I think the file is currently written after the callback is fired, I will change it so it writes the file before firing the callback.

thanks

@BoneTM BoneTM closed this as completed Feb 2, 2021
@BoneTM BoneTM reopened this Feb 2, 2021
@BoneTM BoneTM closed this as completed Feb 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants