-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit failures should fail workflow #370
Labels
good first issue
Good for newcomers
status: pinned
Should not be labeled as stale
type: fix
Updates to existing functionalities
Comments
Josh-Cena
added
the
status: pending
More info is needed before deciding what to do
label
Mar 3, 2022
EndBug
added
type: fix
Updates to existing functionalities
good first issue
Good for newcomers
status: pinned
Should not be labeled as stale
and removed
status: pending
More info is needed before deciding what to do
labels
Mar 3, 2022
@all-contributors please add @Josh-Cena for their bug report |
I've put up a pull request to add @Josh-Cena! 🎉 |
That's quick @EndBug Thanks! (Didn't get time last week to test, but can confirm it works now!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Good for newcomers
status: pinned
Should not be labeled as stale
type: fix
Updates to existing functionalities
Describe the bug
If
git commit
fails, the workflow still completes despite nothing being pushed.Workflow used
https://github.com/Josh-Cena/Josh-Cena.github.io/blob/master/.github/workflows/mark-non-coding-day.yml
Expected behavior
The workflow should exit with a non-zero status so GitHub would put a red cross.
Logs
https://github.com/Josh-Cena/Josh-Cena.github.io/runs/5408061374?check_suite_focus=true
The text was updated successfully, but these errors were encountered: