Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mandatory pulling, use whatever has been checked out. #327

Closed
Darylgolden opened this issue Nov 27, 2021 · 4 comments
Closed

Remove mandatory pulling, use whatever has been checked out. #327

Darylgolden opened this issue Nov 27, 2021 · 4 comments
Assignees
Labels
status: pinned Should not be labeled as stale type: bug Verified problems that need to be worked on

Comments

@Darylgolden
Copy link

Hi, I'm trying to use this action to make changes to a PR branch, at ManimCommunity/manim#2333. When I try to commit however, I get Error: Error: There is no tracking information for the current branch.. This can be seen in the Add & Commit step here. How should I fix this?

@Darylgolden Darylgolden added the type: question Further information is requested label Nov 27, 2021
@EndBug
Copy link
Owner

EndBug commented Nov 28, 2021

It seems like the action is trying to pull from ManimCommunity:translation-ci instead of Darygolden:translation-ci
I don't think there's a way to work around this with the current action code, I think you have to fall back to using git commands for now.

I'll work towards changing the behavior of the action, since I don't like the fact that it has to pull from the branch: I want it to just use whatever has been checked out (which in case of a PR is probably a detached HEAD, not even a branch...)

Sorry for the inconvenient :/

@EndBug EndBug added status: pinned Should not be labeled as stale type: bug Verified problems that need to be worked on and removed type: question Further information is requested labels Nov 28, 2021
@EndBug EndBug self-assigned this Nov 28, 2021
@EndBug EndBug added this to To do in Main board via automation Nov 28, 2021
@EndBug EndBug changed the title Using this action to commit to a PR branch Remove mandatory pulling, use whatever has been checked out. Nov 28, 2021
@EndBug EndBug removed this from To do in Main board Jan 19, 2022
@EndBug EndBug closed this as completed in 6fdb34e Jan 20, 2022
@EndBug
Copy link
Owner

EndBug commented Jan 20, 2022

@all-contributors please add @Darylgolden for their bug report

@allcontributors
Copy link
Contributor

@EndBug

I've put up a pull request to add @Darylgolden! 🎉

@EndBug
Copy link
Owner

EndBug commented Jan 20, 2022

This fix has been added in v8.0.0 (also v8 and latest). Thanks for your issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pinned Should not be labeled as stale type: bug Verified problems that need to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants