Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When submoduling via CMake we get the error "Cannot include blosc2.h" #60

Closed
EmilDohne opened this issue Mar 4, 2024 · 0 comments
Closed
Assignees
Labels
bug Something isn't working build

Comments

@EmilDohne
Copy link
Owner

This is due to the way we construct our include for the PhotoshopAPI target

target_include_directories(PhotoshopAPI PUBLIC include ${CMAKE_SOURCE_DIR}/thirdparty/c-blosc2/include src src/Util)

where a better approach would be to add an INTERFACE target for the include dirs in our top level build and not rely on ${CMAKE_SOURCE_DIR} but instead ${CMAKE_PROJECT_DIR}

This could look a little something like this:

add_library(blosc2_include INTERFACE)
target_include_directories(blosc2_include INTERFACE thirdparty/c-blosc_2/include )
@EmilDohne EmilDohne added bug Something isn't working build labels Mar 4, 2024
@EmilDohne EmilDohne self-assigned this Mar 4, 2024
@EmilDohne EmilDohne mentioned this issue Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build
Projects
None yet
Development

No branches or pull requests

1 participant