Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add re-capture to subscribe and contact form #47

Closed
gsambrotta opened this issue Apr 1, 2021 · 5 comments · Fixed by #155
Closed

Feature: Add re-capture to subscribe and contact form #47

gsambrotta opened this issue Apr 1, 2021 · 5 comments · Fixed by #155
Assignees
Labels
hacktoberfest PR partecipating to https://hacktoberfest.digitalocean.com/

Comments

@gsambrotta
Copy link
Collaborator

As an Elliot For Water User:
When I click the Subscribe Bbutton or Contact Form Send button
Then I should be presented with the "I am not a robot" re-captcha.
https://www.google.com/recaptcha/about/

It maybe also possible to re-implement the Aniti Forgery Token using React and WebApi based on this example;
https://stackoverflow.com/questions/11476883/web-api-and-validateantiforgerytoken

Either approach would be sufficient.
Give priorities to the approach that don't automatically fill in the re-captcha and avoid the user to interact. If possible.

@gsambrotta gsambrotta added the hacktoberfest PR partecipating to https://hacktoberfest.digitalocean.com/ label Oct 4, 2021
@karlrez
Copy link
Contributor

karlrez commented Dec 8, 2021

@ElliotForWater/elliotforwater-team Hi, I've been reading over the project documentation and got the development server running. I would love to help contribute! Can I be assigned to this issue?

@gsambrotta
Copy link
Collaborator Author

@karlrez hi and thank you for your interest in contributing to Elliot For Water. I have assigned the issue to you, feel free to work on it and let me know if you have any further questions or feedbacks.

@karlrez
Copy link
Contributor

karlrez commented Dec 13, 2021

@gsambrotta Hi, I just want to give an update on this and have a question about the UI.

I chose to use reCapcha v2, as it requires the user to interact more and it also generates a token which we can send to the backend: https://developers.google.com/recaptcha/intro
And I am implementing this with this react package: https://www.npmjs.com/package/react-google-recaptcha

Are you able to elaborate more on how this should look on the frontend?
Below shows the recapcha added to both subscribe forms:
image

Would you rather the recapcha to toggle visibility and only show when a user tries to submit their email? Do you have any suggestions on size location of the recapcha? Let me know your thoughts.

@gsambrotta
Copy link
Collaborator Author

Hi @karlrez! Happy to read about your progress. It looks good already :D

I was wondering, why did you choose reCaptchav2 Robot instead invisible one?
Seem to me that the two have the same level of security but with the invisible one the user doesn't have to do any extra action and we have more chance he/she is gonna submit the form.
Also we can hide the element so doesn't visually disturb the user

What do you think?

@karlrez
Copy link
Contributor

karlrez commented Dec 14, 2021

I agree! Apologies, I guess I had misread the feature request and thought we wanted the one with more user interaction.
The invisible one is totally doable and shouldn't change the existing UI at all.

This was referenced Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest PR partecipating to https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants