Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deployment badge to README #11

Closed
gsambrotta opened this issue Feb 28, 2021 · 20 comments
Closed

Add Deployment badge to README #11

gsambrotta opened this issue Feb 28, 2021 · 20 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@gsambrotta
Copy link
Collaborator

Add this cod to the README.md to show the status of the production deployment

Image URL
https://dev.azure.com/E4W/Elliotforwater/_apis/build/status/ElliotForWater.efw-webapp?branchName=main

@gsambrotta gsambrotta added the good first issue Good for newcomers label Feb 28, 2021
@adityaraute
Copy link

Can't do but hope I'll get to learn if someone does.

@ConradParker
Copy link
Collaborator

I've done this a couple of times. I had to grant read access to the repositories first though as the image was being blocked. @Andreae4w I don't have organization-level access to change this. Are you able to? I've attached a screenshot of the setting we need to change.
badges

@Andreae4w
Copy link
Contributor

Andreae4w commented Mar 1, 2021

@gsambrotta @ConradParker @adityaraute I managed to update the settings from Azure. Thanks a lot for letting me know!
@adityaraute if you'd like to give it another try It should be working now.

@adityaraute
Copy link

Yeah, no. Sorry. I am still not sure if I know enough to solve this issue. Would request someone else to take it up.

@gsambrotta
Copy link
Collaborator Author

Hi @adityaraute if you need any help, we can guide you on working on this issue.
If you instead prefer to not work on it, no problem, just let us know.
Is mostlyabout changing our README file adding the above image URL

@adityaraute
Copy link

Yes do not wish to work on it, I will observe from the sidelines. 😄

@sachinh19
Copy link

Isn't this as simple as adding the following line to the README.md file?

![Efw-Webapp-Azure-Production-Development](https://dev.azure.com/E4W/Elliotforwater/_apis/build/status/ElliotForWater.efw-webapp?branchName=main)

@adityaraute
Copy link

Is it? I tried, didn't work.

@sachinh19
Copy link

Maybe I am misunderstanding the requirement here, but as @ConradParker pointed out the image is blocked and we need some access to see the actual status in the forked repository so that it would show the status.

But after that access if granted isn't this the code change that this issue will need to resolve it?

@adityaraute
Copy link

image
This is what I see when I paste the line you have mentioned in the comment. The badge doesn't render.

Hence, would request whoever can solve the issue to take it up.

@gsambrotta
Copy link
Collaborator Author

@sachinh19 you understood the requirement perfectly and yes, it should work adding just that line to the readme file.
To be honest I never add such badges before so I'm not so sure how it works.
We should figured out this together :)
@Andreae4w can you confirm that now the settings in Azure are done in a way that the badge can be shown publicly?
@ConradParker you said you already have done this, do we need to do anything else?

@Andreae4w
Copy link
Contributor

@gsambrotta Yes, I can confirm that. :)

@sachinh19
Copy link

image
This is what I see when I paste the line you have mentioned in the comment. The badge doesn't render.

Hence, would request whoever can solve the issue to take it up.

This is because you do not have access to the repository.

@sachinh19
Copy link

sachinh19 commented Mar 3, 2021

@sachinh19 you understood the requirement perfectly and yes, it should work adding just that line to the readme file.
To be honest I never add such badges before so I'm not so sure how it works.
We should figured out this together :)
@Andreae4w can you confirm that now the settings in Azure are done in a way that the badge can be shown publicly?
@ConradParker you said you already have done this, do we need to do anything else?

Now that the settings in azure are done, just adding that line to the README file should do the trick.

I would suggest one of the owners of the repository to take this change up since there is a good chance that you folks will not see the error that we can see in @adityaraute's screenshot

@ConradParker
Copy link
Collaborator

I can confirm the badge is still not showing. Sorry guys, we were hoping this was an easy one for starting out. I'll take a look at the permissions again. Leave it with me.

@Andreae4w
Copy link
Contributor

@ConradParker @sachinh19 @adityaraute sorry guys, I have just noticed it did not take my change of settings on Azure. I have just corrected it and should be fine now.

@ConradParker
Copy link
Collaborator

@ConradParker @sachinh19 @adityaraute sorry guys, I have just noticed it did not take my change of settings on Azure. I have just corrected it and should be fine now.

Thanks @Andreae4w , It's still not working for me so I'll keep investigating.

@ConradParker ConradParker self-assigned this Mar 3, 2021
@gsambrotta
Copy link
Collaborator Author

thank you @ConradParker and everybody that helped! 🎉

@adityaraute
Copy link

Wait, it's done? I don't see a linked PR.

@gsambrotta
Copy link
Collaborator Author

Ah, right. here it is: #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants