Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chatglm2 acc=0 on lambada_openai dataset, is it correct? #959

Open
changwangss opened this issue Nov 2, 2023 · 3 comments
Open

chatglm2 acc=0 on lambada_openai dataset, is it correct? #959

changwangss opened this issue Nov 2, 2023 · 3 comments
Labels
bug Something isn't working.

Comments

@changwangss
Copy link
Contributor

I also validate chatglm and chatglm3, they are works, could you have fix the root cause?
https://huggingface.co/THUDM/chatglm2-6b/discussions/97
python main.py --model hf-causal --model_args pretrained=THUDM/chatglm2-6b,trust_remote_code=True --tasks lambada_openai --limit 10 --batch_size 1 --no_cache

@StellaAthena
Copy link
Member

When I run this I get AttributeError: property 'pad_token_id' of 'ChatGLMTokenizer' object has no setter. You're seeing it run though?

@StellaAthena StellaAthena added the bug Something isn't working. label Nov 2, 2023
@changwangss
Copy link
Contributor Author

changwangss commented Nov 9, 2023

as the code show, https://huggingface.co/THUDM/chatglm2-6b/blob/main/tokenization_chatglm.py#L91
yes, correct, the pad_token or pad_token_id is property and has no setter.
I comment tokenizer.pad_token = tokenizer.eos_token, I can get the acc about chatglm&chatglm3, but acc=0 for chatglm2.
Could you give me some help?

@haileyschoelkopf
Copy link
Contributor

ChatGLM-6B and ChatGLM3-6b both seem to work fine. I'm still unsure as to what's going wrong on ChatGLM2 and would very much like to figure out how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
Status: Ready
Development

No branches or pull requests

3 participants