Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quac Dataset #827

Open
RanchiZhao opened this issue Sep 4, 2023 · 8 comments
Open

Quac Dataset #827

RanchiZhao opened this issue Sep 4, 2023 · 8 comments
Labels
feature request A feature that isn't implemented yet. good first issue Good for newcomers

Comments

@RanchiZhao
Copy link

When will you support evaluation on the quac dataset? I found the results of the Llama2 paper difficult to reproduce. Especially regarding how to segment the answer for the base model's F1 score.

@RanchiZhao
Copy link
Author

RanchiZhao commented Sep 15, 2023

are there any solutions? i am confused

@StellaAthena StellaAthena added feature request A feature that isn't implemented yet. good first issue Good for newcomers labels Oct 14, 2023
@glerzing
Copy link

glerzing commented Nov 1, 2023

If nobody is already working on it, I can try this feature.

@StellaAthena
Copy link
Member

If nobody is already working on it, I can try this feature.

That would be great!

@Sanchit-404
Copy link

Hi @glerzing are you working on quac? If not, i can take that.

@glerzing
Copy link

Yes, I'm on it. It's a bit more complicated than I expected, it will probably take weeks.

@glerzing
Copy link

glerzing commented Mar 2, 2024

Actually, I will not have the opportunity to finish it, sorry. I had other important things to do.
The implementation should be quite similar to the one of CoQA, but to avoid having the same problem as with #1231 , you need a way to make a list of predictions for each document, probably by implementing construct_requests. @Sanchit-404, if you are still motivated, feel free to pick this issue.

@glerzing glerzing removed their assignment Mar 2, 2024
@adiprasad
Copy link

Hi, any updates on this ?

@glerzing if you have a partial implementation or high level plan, please share it, will be helpful for anyone to pick it up

@glerzing
Copy link

The Python script is too much of a draft to share. It's not worth much, but here is the README.md. I would have liked to have a yaml file like this like this, with the ability to redefine construct_requests inside the yaml file, like with doc_to_text or process_results. That would be cleaner than having to implement it with a class that inherits from Task like in squadv2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A feature that isn't implemented yet. good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants