Implement PTB evaluation
#135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 83.85% 75.47% -8.38%
==========================================
Files 43 34 -9
Lines 3048 2035 -1013
==========================================
- Hits 2556 1536 -1020
- Misses 492 499 +7
Continue to review full report at Codecov.
|
It now takes loglikelihood of full sentence rather than just last word. Length normalizing is done using the *original*, pre-detokenization word count.
|
Blocked on figuring out why the heck our score is an order of magnitude worse than the value for 117M in the GPT2 paper |
# Conflicts: # lm_eval/tasks/__init__.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the Penn Treebank evaluation as described in #5