Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making torch dep optional? #1959

Open
dlwh opened this issue Jun 12, 2024 · 4 comments · May be fixed by #2004
Open

Making torch dep optional? #1959

dlwh opened this issue Jun 12, 2024 · 4 comments · May be fixed by #2004

Comments

@dlwh
Copy link

dlwh commented Jun 12, 2024

Hi,

For those of us JAX cultists, any chance we could make torch an optional dependency? I think the only place the main framework needs torch is for the distributed evaluation stuff in evaluator.py, which can be import-guarded with a few lines' fix.

@dlwh
Copy link
Author

dlwh commented Jun 13, 2024

(I'd be happy to PR this if you all are interested)

@lintangsutawika
Copy link
Contributor

Happy to review your PR. Also it would be great if there is some sort of example on how you using in jax for beginners, just an idea.

@haileyschoelkopf
Copy link
Contributor

Hey @dlwh ! Echoing this--happy to see a PR making this change, and we can discuss there whether the changes are self-contained enough to merge generally. Should be a good idea to support JAX.

@dlwh
Copy link
Author

dlwh commented Jun 20, 2024

@lintangsutawika Sounds like a good idea. I'm gonna PR the core change first just as a POC and once I have things working on my end I'll try to make a tutorial

@dlwh dlwh linked a pull request Jun 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants