-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making torch dep optional? #1959
Comments
(I'd be happy to PR this if you all are interested) |
Happy to review your PR. Also it would be great if there is some sort of example on how you using in jax for beginners, just an idea. |
Hey @dlwh ! Echoing this--happy to see a PR making this change, and we can discuss there whether the changes are self-contained enough to merge generally. Should be a good idea to support JAX. |
@lintangsutawika Sounds like a good idea. I'm gonna PR the core change first just as a POC and once I have things working on my end I'll try to make a tutorial |
Hi,
For those of us JAX cultists, any chance we could make torch an optional dependency? I think the only place the main framework needs torch is for the distributed evaluation stuff in evaluator.py, which can be import-guarded with a few lines' fix.
The text was updated successfully, but these errors were encountered: