Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add asdiv task #244

Merged
merged 7 commits into from
Jan 4, 2022
Merged

add asdiv task #244

merged 7 commits into from
Jan 4, 2022

Conversation

rokosbasilisk
Copy link

No description provided.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.


# Language Model Evaluation Harness

![](https://github.com/EleutherAI/lm-evaluation-harness/workflows/Build/badge.svg)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

@leogao2
Copy link
Contributor

leogao2 commented Dec 29, 2021

If I remember correctly the reason we never merged the original PR was because the gpt2 results didnt line up with the numbers in the paper; do you have eval numbers for the new PR?

@rokosbasilisk
Copy link
Author

rokosbasilisk commented Dec 29, 2021

the paper does'nt mention any LLM results.

@leogao2
Copy link
Contributor

leogao2 commented Dec 29, 2021

Oh, I must have gotten it mixed up with another task then

eval.sh Outdated Show resolved Hide resolved
lm_eval/tasks/asdiv.py Outdated Show resolved Hide resolved
lm_eval/tasks/asdiv.py Outdated Show resolved Hide resolved
lm_eval/tasks/asdiv.py Show resolved Hide resolved
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

lm_eval/tasks/asdiv.py Outdated Show resolved Hide resolved
@rokosbasilisk
Copy link
Author

Is there an available implementation of this to try for this task?

@StellaAthena StellaAthena linked an issue Dec 31, 2021 that may be closed by this pull request
leogao2
leogao2 previously approved these changes Jan 1, 2022
Copy link
Contributor

@leogao2 leogao2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally

@leogao2 leogao2 merged commit 8728710 into EleutherAI:master Jan 4, 2022
qmdnls pushed a commit to qmdnls/lm-evaluation-harness that referenced this pull request Aug 17, 2023
LZY-the-boys pushed a commit to LZY-the-boys/lm-evaluation-harness-fast that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the ASDiv Evaluation
3 participants