Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--device cuda:3 not honored when using --model vllm #1846

Open
LGLG42 opened this issue May 15, 2024 · 3 comments
Open

--device cuda:3 not honored when using --model vllm #1846

LGLG42 opened this issue May 15, 2024 · 3 comments
Labels
bug Something isn't working. documentation Improvements or additions to documentation.

Comments

@LGLG42
Copy link

LGLG42 commented May 15, 2024

Hi, I've just found the hard way that the --device cuda:X does not do anything when using --model vllm, the only way to force it to use an specific GPU is to pass 'CUDA_VISIBLE_DEVICES=1' to the "lm_eval" command.

@baberabb
Copy link
Contributor

Hi! yeah that's the only way with vllm unfortunately. Would you like to add a logging message here to inform other users about this limitation?

@johnwee1
Copy link
Contributor

Hi! yeah that's the only way with vllm unfortunately. Would you like to add a logging message here to inform other users about this limitation?

+1, I had to skim through the code and it was only because this issue was raised that I could confidently run without accidentally causing errors (because i had other GPUs that were being used as well.)

for anyone else reading this, CUDA_VISIBLE_DEVICES=1,2,3 as a comma separated list is how you would specify multiple GPUs

@haileyschoelkopf
Copy link
Collaborator

We could manually set os.environ["CUDA_VISIBLE_DEVICES"] in the code right?

I'm agnostic as to which solution -- setting the env variable ourselves, or just printing a warning log stating that device won't be respected -- open to feedback from users on which they would find more intuitive.

@haileyschoelkopf haileyschoelkopf added bug Something isn't working. documentation Improvements or additions to documentation. labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. documentation Improvements or additions to documentation.
Projects
None yet
Development

No branches or pull requests

4 participants