Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch_size with auto defaults to 1 if No executable batch size found is raised #1405

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

pminervini
Copy link
Contributor

Fixes #1323

@pminervini
Copy link
Contributor Author

pminervini commented Feb 7, 2024

Doing some more stress tests just in case -- done, everything seems fine!

@pminervini pminervini changed the title batch_size with auto defaults to 1 if No executable batch size found batch_size with auto defaults to 1 if No executable batch size found is raised Feb 7, 2024
Copy link
Contributor

@haileyschoelkopf haileyschoelkopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pminervini !

@haileyschoelkopf haileyschoelkopf merged commit 4c17c55 into EleutherAI:main Feb 7, 2024
8 checks passed
@pminervini pminervini deleted the auto-batch-size branch February 8, 2024 17:38
wx-zhang pushed a commit to wx-zhang/lm-evaluation-harness that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch size auto is wrong?
2 participants