Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for top-k metrics with num_return_sequences>1 #1117

Open
yuyemin opened this issue Dec 13, 2023 · 3 comments
Open

Support for top-k metrics with num_return_sequences>1 #1117

yuyemin opened this issue Dec 13, 2023 · 3 comments
Assignees
Labels
feature request A feature that isn't implemented yet.

Comments

@yuyemin
Copy link

yuyemin commented Dec 13, 2023

Hi, I wonder if lm-eval supports top-k evaluation when generating with beam_search with num_return_sequences>1 ?

@haileyschoelkopf
Copy link
Contributor

Hi! We don't currently support num_return_sequences > 1, and mostly focus on support for Top-P / Top-K temperature sampling, though we do support running generation K times per document to get K different completions via repeats: K in a task YAML.

Could you explain exactly what "top-K evaluation" means in this context?

If you'd be interested in opening a PR to help support this or streamline evaluation in the num_return_sequences > 1 / beam search setting we'd be happy to accept it!

@yuyemin
Copy link
Author

yuyemin commented Dec 13, 2023

Thanks for the quick reply! I'm aiming to evaluate the top-k exact-match metric (check if there's a ground-truth hit in top-k lowest-perplexity candidates generated using beam-search + num_return_sequences=k).

In that case, I'll see if I can work on incorporating this feature and open a PR afterwards.

Hi! We don't currently support num_return_sequences > 1, and mostly focus on support for Top-P / Top-K temperature sampling, though we do support running generation K times per document to get K different completions via repeats: K in a task YAML.

Could you explain exactly what "top-K evaluation" means in this context?

If you'd be interested in opening a PR to help support this or streamline evaluation in the num_return_sequences > 1 / beam search setting we'd be happy to accept it!

@StellaAthena StellaAthena added the feature request A feature that isn't implemented yet. label Dec 18, 2023
@ChengJade
Copy link

Thanks for the quick reply! I'm aiming to evaluate the top-k exact-match metric (check if there's a ground-truth hit in top-k lowest-perplexity candidates generated using beam-search + num_return_sequences=k).

In that case, I'll see if I can work on incorporating this feature and open a PR afterwards.

Hi! We don't currently support num_return_sequences > 1, and mostly focus on support for Top-P / Top-K temperature sampling, though we do support running generation K times per document to get K different completions via repeats: K in a task YAML.
Could you explain exactly what "top-K evaluation" means in this context?
If you'd be interested in opening a PR to help support this or streamline evaluation in the num_return_sequences > 1 / beam search setting we'd be happy to accept it!

Hi, sorry to disturb you, just wondering have you worked out this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A feature that isn't implemented yet.
Projects
Status: In progress
Development

No branches or pull requests

4 participants