Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor main evaluate() loop into more readable sub-functions #1100

Open
haileyschoelkopf opened this issue Dec 11, 2023 · 2 comments
Open

Refactor main evaluate() loop into more readable sub-functions #1100

haileyschoelkopf opened this issue Dec 11, 2023 · 2 comments
Assignees
@baberabb
Labels
documentation Improvements or additions to documentation. feature request A feature that isn't implemented yet.

Comments

@haileyschoelkopf
Copy link
Collaborator

No description provided.

@haileyschoelkopf haileyschoelkopf added documentation Improvements or additions to documentation. feature request A feature that isn't implemented yet. labels Dec 11, 2023
@baberabb
Copy link
Contributor

I can work on this! Will create a draft PR

@haileyschoelkopf
Copy link
Collaborator Author

haileyschoelkopf commented Feb 6, 2024 •
edited

Refactoring would include:

  • Handling the many defaultdicts more cleanly such as via a dataclass
  • Likely refactoring the requests-gathering (right now, lines 434 - 483 after PR 1390 merges) into a helper function
  • Cleaning up the fact that alias and samples keys are added to metrics and get popped from the dicts
  • Placing print_tasks and the loop from L601-617 outside the main loop perhaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baberabb baberabb

Labels
documentation Improvements or additions to documentation. feature request A feature that isn't implemented yet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haileyschoelkopf @baberabb