fixed case when ntasks_per_node is used, leading to missing SLURM_NTASKS env var #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Quentin-Anthony
approved these changes
Nov 1, 2023
R0n12
pushed a commit
to R0n12/gpt-neox-fork
that referenced
this pull request
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some clusters, it appears that a script specifying
#SBATCH --ntasks_per_nodeinstead of#SBATCH --ntaskswill fail to build the environment variableos.environ["SLURM_NTASKS"]. This leads to an error inarguments.py, due to accessing a non-existing key ofos.environ. A simple fix is to note that NTASKS = NNODES x SLURM_NTASKS_PER_NODE and use the right handside if theSLURM_NTASKSkey does not exist inos.environ.