Fused kernel support for AMD (using JIT) #1156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocm 4.5.2 compliant
|
Lang Xu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Will start a new branch and PR with all these changes, current state looks kinda messy. |
|
Closing in anticipation of the clean PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR aims to bring JIT support into building fused kernels. The main reason for the swtich is that hip extension acts weird (making ninja generates different rules for the same target) with the traditional
CUDAExtensionsetup, thus in this PR we usecpp_extension.load(), this enables no code modification when building across AMD and NVIDIA platformsHeads-up
This PR also bring in the
cpp_extention_load_helperfrom here, note that we JIT load fused kernels on demand and depends onneox_args, this may introduce additional complexity in testing, for fused kernels testing, I recommend keeping the originalsetup.pyfile as a backup.Aim to close #954