Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do pythia untied embedding and unembedding matrics? #913

Closed
Life-0-1 opened this issue May 1, 2023 · 5 comments
Closed

Do pythia untied embedding and unembedding matrics? #913

Life-0-1 opened this issue May 1, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@Life-0-1
Copy link

Life-0-1 commented May 1, 2023

In the Pythia paper, it is stated that embedding and unembedding matrics are untied.

But I find that config files of all kinds of pythia models are with the no_weight_tying remaining a default value of False, which results a tying between embed and unembed layers.

Is this a bug? What setting did you actually use while training pythia?

@Life-0-1 Life-0-1 added the bug Something isn't working label May 1, 2023
@haileyschoelkopf
Copy link
Contributor

Which config files are you looking at? the ones in the Pythia repo and the ones here https://github.com/EleutherAI/gpt-neox/blob/main/configs/pythia/1-4B.yml use the value “no-weight-tying”: true as expected.

@Life-0-1
Copy link
Author

Life-0-1 commented May 1, 2023

Which config files are you looking at? the ones in the Pythia repo and the ones here https://github.com/EleutherAI/gpt-neox/blob/main/configs/pythia/1-4B.yml use the value “no-weight-tying”: true as expected.

Sorry, I Made a mistake. I searched config files and found no no_weight_tying() , but there is no-weight-tying.

"-" and "_" are different from readme and config files.

@Life-0-1 Life-0-1 closed this as completed May 1, 2023
@StellaAthena
Copy link
Member

@Life-0-1 what readme are you talking about? The one in gpt-neox/configs uses -

@Life-0-1
Copy link
Author

Life-0-1 commented May 4, 2023

@Life-0-1 what readme are you talking about? The one in gpt-neox/configs uses -

gpt-neox/configs/neox_arguments.md this one.

@StellaAthena
Copy link
Member

Opened an issue to fix the inconsistency #920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants