-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Generation / Eval with deepspeed model engine #58
Comments
Where in the code does this happen? |
at the end of train_enwik8.py for example-the commented code. |
but actually I see that it's already changed on train.py:
|
Huh, funny oversight. Yeah, push a patch to the generate function and we’ll close this issue. |
actually it's not possible to just change "model" to "model_engine" for generation. |
Superseded by codebase refactoring. |
currently Generation / Eval are happening with the pytorch model, not the model engine. This is already causing memory problems and won't allow us to scale up - we'll need to implement this with the deepspeed model engine.
The text was updated successfully, but these errors were encountered: