Pipeline Parallel QoL Fixes #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 14, 2021
Minor tweak to `forward` to align better with the demo code
Forgot about the open PR and pushed dev code to this branch.
* Pipeline + Checkpoint - ZeRO 2 This illustrates the third combination: pipeline parallelism, activation checkpoints, and ZeRO Stage 1. Again, this works. Upgrading ZeRO to Stage 2 causes it to fail. Co-authored-by: Shivanshu Purohit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contributes the
train_parallel.pyfile which is an implementation of GPT-3 Small training with pipeline parallelism.Additionally, several quality of life improvements have been made. Most notably, there are now separate configs and scripts for using ZeRO 1 and ZeRO 2. Several files have been renamed to give a more accurate description of what they contain.
Finally, I want to merge back into the main branch to avoid unreconcilable divergences. The longer this branch remains separate, the more likely that is.
As of this PR, both Pipeline Parallelism and Activation Checkpointing work individually, but not collectively. See Issue #62 for this bug report.