Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[temporary] fix to index errors in datasets #378

Merged
merged 2 commits into from
Jul 20, 2021
Merged

[temporary] fix to index errors in datasets #378

merged 2 commits into from
Jul 20, 2021

Conversation

sdtblck
Copy link
Contributor

@sdtblck sdtblck commented Jul 19, 2021

No description provided.

@sdtblck sdtblck requested a review from a team as a code owner July 19, 2021 09:30
StellaAthena
StellaAthena requested changes Jul 20, 2021
View reviewed changes
Copy link
Member

@StellaAthena StellaAthena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very temporary patch, but it's good to be able to run the code.

@StellaAthena StellaAthena self-requested a review July 20, 2021 14:17
StellaAthena
StellaAthena approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@StellaAthena StellaAthena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicked "request changes" by accident :/

@StellaAthena StellaAthena merged commit cf36e17 into main Jul 20, 2021
@StellaAthena StellaAthena deleted the dataset_fix branch July 20, 2021 14:18
@StellaAthena StellaAthena linked an issue Jul 20, 2021 that may be closed by this pull request
Index Errors with Weighted Dataset #377
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StellaAthena StellaAthena StellaAthena approved these changes

@lucidrains lucidrains Awaiting requested review from lucidrains

@ConnorJL ConnorJL Awaiting requested review from ConnorJL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Index Errors with Weighted Dataset
2 participants
@sdtblck @StellaAthena