Add improved data downloading class / pipeline #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sdtblck
commented
Jan 5, 2021
sdtblck
commented
- run prepare_dataset.py with your model args to download the required dataset (if you run with deepspeed it downloads once for every rank)
- to add a new dataset, create a class that inherits from DataDownloader and add it to the DATA_DOWNLOADERS registry
|
Have now added the dataset downloading to the main train scripts so you don't have to run a separate python file. |
|
Also removed adam optimizer if using deepspeed - passing in an optimizer override's deepspeed's ZeRO optimizer, which we want to use |
This was
linked to
issues
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.