Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added shampoo optimizer from https://github.com/jettify/pytorch-opti… #430

Closed
wants to merge 4 commits into from
Closed

added shampoo optimizer from https://github.com/jettify/pytorch-opti… #430

wants to merge 4 commits into from

Conversation

rokosbasilisk
Copy link

…mizer/blob/master/torch_optimizer/shampoo.py

@rokosbasilisk rokosbasilisk requested a review from a team as a code owner October 18, 2021 16:02
@StellaAthena StellaAthena linked an issue Oct 18, 2021 that may be closed by this pull request
Add shampoo optimizer #314
Open
@rokosbasilisk rokosbasilisk requested review from StellaAthena and removed request for StellaAthena October 18, 2021 17:29
@StellaAthena
Copy link
Member 

#authors:
 #  - family-names: Novik
 #    given-names: Mykola
 #    orcid: https://orcid.org/0000-0002-0890-1159
 #title: "torch-optimizer -- collection of optimization algorithms for PyTorch."
 #version: 1.0.1
 #date-released: 2020-01-11

This is the original author, not you, right?

@rokosbasilisk
Copy link
Author

rokosbasilisk commented Oct 23, 2021 •
edited
Loading

yes added the same

StellaAthena
StellaAthena requested changes Oct 26, 2021
View reviewed changes
Copy link
Member

@StellaAthena StellaAthena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rokosbasilisk Thank you for your contribution to GPT-NeoX! This looks generally correct, but needs a little more work before it can be integrated into the GPT-NeoX codebase. We have some rather extensive configuration validations and Shampoo needs to be added to that.

Please register the Shampoo optimizer and define the requisite hyperparameters here.

@rokosbasilisk
Copy link
Author

okay, doing.

@StellaAthena
Copy link
Member

okay, doing.

Thanks!

@StellaAthena
Copy link
Member

@rokosbasilisk any updates?

@rokosbasilisk
Copy link
Author

added a sample config at configs/small_shampoo.yml

@StellaAthena
Copy link
Member

Closing as too far behind main to be merged. May require substantial refactors to get working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StellaAthena StellaAthena StellaAthena requested changes

@kingoflolz kingoflolz Awaiting requested review from kingoflolz kingoflolz was automatically assigned from EleutherAI/pm-gptneo

@EricHallahan EricHallahan Awaiting requested review from EricHallahan EricHallahan was automatically assigned from EleutherAI/pm-gptneo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add shampoo optimizer
3 participants
@rokosbasilisk @StellaAthena @xagi-dev