Remove global vars #277
Merged
Remove global vars #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 29, 2021 15:39
added 20 commits
April 30, 2021 12:44
…nto remove_global_vars
Closed
StellaAthena
approved these changes
Apr 30, 2021
sdtblck
reviewed
Apr 30, 2021
| logits = logits[:, -1].view(batch_size, -1).contiguous() | ||
|
|
||
| if args.greedy: | ||
| # we have to use neox_args instead of kwargs here because deepspeed :| |
There was a problem hiding this comment.
This reverts this bugfix here #253
sdtblck
reviewed
Apr 30, 2021
|
|
||
| local_rank = os.environ.get("LOCAL_RANK") | ||
| if local_rank is None: | ||
| print("utils.local_rank() environment variable LOCAL_RANK not set, defaulting to 0", flush=True) |
There was a problem hiding this comment.
I think we should default to -1 here? (torch / deepspeed's default if local rank isn't set, i.e we're not distributed.)
There was a problem hiding this comment.
Some functions rely on rank being equal to 0 (e.g. tensorboard initialization
gpt-neox/megatron/neox_arguments/arguments.py
Line 106 in 319ad17
Line 17 in 319ad17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests removes the global variables. Exception are mpu global variables. These are more complicated and potentially breaking due to being used in torch. autograd.Function implementations.
Train for some steps on small config results in equal loss graphs:
Tests are adjusted to the new setup and pass: