Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacturing Config #245

Closed
sweinbach opened this issue Apr 21, 2021 · 0 comments · Fixed by #249
Closed

Refacturing Config #245

sweinbach opened this issue Apr 21, 2021 · 0 comments · Fixed by #249
Assignees
Labels
feature request New feature or request

Comments

@sweinbach
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Trying to get neox to run, one notices complexity in the way config is provided to different components. Refacturing may increase readability and testability of code.

Describe the solution you'd like

  • One data class (may be still global) including separate data classes by purpose (model, deepspeed)
  • data class can update values from .yml files
  • data class can return formatted output (e.g. for deepspeed call)
  • data class can print config values
  • data class can do other stuff currently implemented in megatron/arguments and megatron/config_monser.py
@sweinbach sweinbach added the feature request New feature or request label Apr 21, 2021
@StellaAthena StellaAthena linked a pull request Apr 24, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants