Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer logging innacurate if pp=0 #238

Closed
sdtblck opened this issue Apr 17, 2021 · 0 comments · Fixed by #269
Closed

Timer logging innacurate if pp=0 #238

sdtblck opened this issue Apr 17, 2021 · 0 comments · Fixed by #269
Labels
bug Something isn't working

Comments

@sdtblck
Copy link
Contributor

sdtblck commented Apr 17, 2021

if pp = 0 (and the model is initiated using megatron's base model instead of the pipeline parallel model) then it considers a single microbatch a step, and so the flops/timer logging is inaccurate.
@sdtblck sdtblck added the bug Something isn't working label Apr 17, 2021
@sdtblck sdtblck linked a pull request Apr 28, 2021 that will close this issue
Cull pp = 0 model branch #269
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cull pp = 0 model branch EleutherAI/gpt-neox
1 participant
@sdtblck