Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Tests / Style Tests #221

Closed
4 tasks
sdtblck opened this issue Apr 9, 2021 · 2 comments · Fixed by #256
Closed
4 tasks

Add Unit Tests / Style Tests #221

sdtblck opened this issue Apr 9, 2021 · 2 comments · Fixed by #256
Labels
documentation Improvements or additions to documentation feature request New feature or request good first issue Good for newcomers

Comments

@sdtblck
Copy link
Contributor

sdtblck commented Apr 9, 2021

Describe the solution you'd like
Add unit tests to check:

We should add these into github actions where possible (i.e if the unit tests can run on CPU rather than GPU)

@sdtblck sdtblck added feature request New feature or request documentation Improvements or additions to documentation good first issue Good for newcomers labels Apr 9, 2021
@itsabhianant
Copy link

Hi @sdtblck,

I know how to create unit tests but I'm not very proficient in doing so. I have a basic idea of how unit test work and how to create one. I can help you resolve this issue but I will need support from you because I find this issue a great opportunity for getting more familiar with creating test cases and testing programs. If you are willing to help me solve this issue please do assign this issue to me and also explain this issue in brief.

I will be pleased if I get the opportunity to solve this issue as it will help me a lot.

Best,
Abhishek

@sdtblck
Copy link
Contributor Author

sdtblck commented Apr 10, 2021

Hi @itsabhianant ! Thanks for reaching out!
I can't really hold your hand through the process, but I can point you to some good resources.
I would recommend you start by looking at deepspeed's unit tests. They do quite a similar thing to what we'd like to do, and the codebase is also similar. https://github.com/microsoft/DeepSpeed/tree/master/tests

Specifically we may want to add some tests similar to the ones here: https://github.com/microsoft/DeepSpeed/tree/master/tests/model/Megatron_GPT2

@sweinbach sweinbach linked a pull request Apr 26, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature request New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants