Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logging.py #248

Merged
merged 2 commits into from
Apr 25, 2021
Merged

Update logging.py #248

merged 2 commits into from
Apr 25, 2021

Conversation

sdtblck
Copy link
Contributor

@sdtblck sdtblck commented Apr 22, 2021

Should fix #216

@sdtblck sdtblck requested a review from a team as a code owner April 22, 2021 13:11
kingoflolz
kingoflolz reviewed Apr 22, 2021
View reviewed changes
megatron/logging.py Outdated Show resolved Hide resolved
@StellaAthena StellaAthena merged commit 3778af3 into main Apr 25, 2021
@StellaAthena StellaAthena deleted the Tee-patch branch April 25, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingoflolz kingoflolz kingoflolz left review comments

@StellaAthena StellaAthena StellaAthena approved these changes

@leogao2 leogao2 Awaiting requested review from leogao2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error upon finishing a run
3 participants
@sdtblck @kingoflolz @StellaAthena