Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Sampling works correctly #152

Closed
sdtblck opened this issue Mar 2, 2021 · 2 comments · Fixed by #160
Closed

Ensure Sampling works correctly #152

sdtblck opened this issue Mar 2, 2021 · 2 comments · Fixed by #160
Assignees
@joshlk
Labels
experiments Experiments we wish to perform on the codebase feature request New feature or request

Comments

@sdtblck
Copy link
Contributor

sdtblck commented Mar 2, 2021

There's code inherited from megatron for sampling from the model but we should ensure we can get this working with the deepspeed / pipeline parallel model too.

See https://github.com/EleutherAI/gpt-neox/blob/main/tools/generate_samples_gpt2.py
@joshlk
Copy link
Member

joshlk commented Mar 3, 2021

I could pick this up if no one else is

@StellaAthena
Copy link
Member

I could pick this up if no one else is

yeah definitely.

@joshlk joshlk mentioned this issue Mar 5, 2021
Merged
5 tasks
@StellaAthena StellaAthena added feature request New feature or request experiments Experiments we wish to perform on the codebase labels Mar 5, 2021
@StellaAthena StellaAthena linked a pull request Mar 5, 2021 that will close this issue
Model sampling/text generation #160
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshlk joshlk

Labels
experiments Experiments we wish to perform on the codebase feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Model sampling/text generation EleutherAI/gpt-neox
3 participants
@joshlk @StellaAthena @sdtblck