Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out why 1-bit Adam pretends to run #128

Closed
StellaAthena opened this issue Feb 17, 2021 · 0 comments · Fixed by #153
Closed

Figure out why 1-bit Adam pretends to run #128

StellaAthena opened this issue Feb 17, 2021 · 0 comments · Fixed by #153
Labels
bug Something isn't working documentation Improvements or additions to documentation experiments Experiments we wish to perform on the codebase
Projects
1T or BUST

Comments

@StellaAthena
Copy link
Member

We have been mystified by the fact that we haven’t seen any speed-up from 1-bit Adam, but we recently discovered that it requires OpenMPI to function. This explains the lack of improvement (we do not currently have a working OpenMPI implementation) but does not explain why the code acts like it runs without a problem. There are two tasks here:

[ ] figure out the code is currently doing
[ ] figure out how to get 1-bit Adam to work (once OpenMPI exists)
@StellaAthena StellaAthena added bug Something isn't working documentation Improvements or additions to documentation experiments Experiments we wish to perform on the codebase labels Feb 17, 2021
@StellaAthena StellaAthena added this to To do in 1T or BUST via automation Feb 17, 2021
@sdtblck sdtblck closed this as completed Mar 4, 2021
1T or BUST automation moved this from To do to Done Mar 4, 2021
@StellaAthena StellaAthena linked a pull request Mar 4, 2021 that will close this issue
Onebit-adam #153
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation experiments Experiments we wish to perform on the codebase
Projects
1T or BUST
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Onebit-adam EleutherAI/gpt-neox
2 participants
@StellaAthena @sdtblck