From 1c133bff4fa172880b50af98dce8cd5c4064a6b8 Mon Sep 17 00:00:00 2001
From: Lang Xu <59843980+R0n12@users.noreply.github.com>
Date: Mon, 29 Jan 2024 20:30:11 -0500
Subject: [PATCH] moved eval import and added to docs (#1139)

---
 configs/neox_arguments.md | 9 +++++----
 megatron/training.py      | 3 ++-
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/configs/neox_arguments.md b/configs/neox_arguments.md
index 28b6e77db..0731a5655 100644
--- a/configs/neox_arguments.md
+++ b/configs/neox_arguments.md
@@ -976,7 +976,7 @@ Text Generation arguments
 
 - **prompt_end**: str
 
-    Default = 
+    Default =
 
 
     a single prompt's end. Defaults to newline
@@ -1018,7 +1018,7 @@ Text Generation arguments
 
 - **eval_results_prefix**: str
 
-    Default = 
+    Default =
 
     prefix to which to save evaluation results - final fp will be {eval_results_prefix}_eval_results_yy-mm-dd-HH-MM.json
 
@@ -1030,6 +1030,8 @@ Text Generation arguments
 
     Tasks to evaluate on using lm_eval_harness
 
+    NOTE: Requires internet connection
+
 
 
 ## NeoXArgsTokenizer
@@ -1768,7 +1770,7 @@ Args for deepspeed config
 
     Default = None
 
-    
+
 
 
 
@@ -2068,4 +2070,3 @@ Args for deepspeed runner (deepspeed.launcher.runner).
     Default = None
 
     Adds a `--account` to the DeepSpeed launch command. In DeeperSpeed this is passed on to the SlurmLauncher as well. Sometimes necessary for cluster rules, or so I've heard.
-
diff --git a/megatron/training.py b/megatron/training.py
index 9b8104400..0f9b36f0b 100644
--- a/megatron/training.py
+++ b/megatron/training.py
@@ -55,7 +55,6 @@
     CharCounter,
 )
 from megatron.model.gpt2_model import cross_entropy
-from eval_tasks import run_eval_harness
 
 
 def mup_weights_reinit(neox_args, model):
@@ -967,6 +966,8 @@ def evaluate(
         )
 
     if neox_args.eval_tasks:
+        from eval_tasks import run_eval_harness
+
         eval_results.update(
             run_eval_harness(
                 model, forward_step_fn, neox_args, eval_tasks=neox_args.eval_tasks