Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 256 - ValueError mutable default #263

Merged

Conversation

artkpv
Copy link
Contributor

@artkpv artkpv commented Jun 27, 2023

Fixes issue #256 (#256) . Error message:

ValueError: mutable default <class 'elk.training.train.Elicit'> for field run_template is not allowed: use
default_factory

artkpv and others added 2 commits June 27, 2023 11:32
Fixes issue EleutherAI#256. Error message:

> ValueError: mutable default <class 'elk.training.train.Elicit'> for field run_template is not allowed: use
default_factory
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2023

CLA assistant check
All committers have signed the CLA.

elk/training/train.py Outdated Show resolved Hide resolved
@norabelrose
Copy link
Member

If we need to change this for Python 3.11 I would prefer to just use functools.partial or something similar.

@norabelrose norabelrose merged commit 670eaec into EleutherAI:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants