Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try loading models from the cwd ever #223

Merged
merged 4 commits into from
Apr 29, 2023
Merged

Don't try loading models from the cwd ever #223

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95329b9
Don't try loading models from the cwd ever
norabelrose Apr 29, 2023
2cec7b0
Throw a more helpful error in cross-device cases
norabelrose Apr 29, 2023
d2e1004
Better error message
norabelrose Apr 29, 2023
ab4dec0
Use prevent_name_conflicts instead
norabelrose Apr 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Throw a more helpful error in cross-device cases
  • Loading branch information
@norabelrose
norabelrose committed Apr 29, 2023
commit 2cec7b09aa3e0d843010a76931d60c64ef8be01e
9 changes: 8 additions & 1 deletion elk/utils/data_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,14 @@ def temporary_dir_move(path: Path | str):
with TemporaryDirectory() as tmp:
if path.exists():
dest = Path(tmp) / path.name
path.rename(dest)
try:
path.rename(dest)
except OSError as e:
print(
f"You have a local directory '{dest.absolute()}' whose name "
f"conflicts with {path}. We tried to move it for you, but failed "
f" with error '{e}'. Please rename the directory and try again."
)
else:
dest = None

Expand Down