Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automatic type checking to the linting pipeline #72

Closed
norabelrose opened this issue Feb 15, 2023 · 1 comment
Closed

Add automatic type checking to the linting pipeline #72

norabelrose opened this issue Feb 15, 2023 · 1 comment
Assignees
@reaganjlee
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
PyPI 0.2 Release

Comments

@norabelrose
Copy link
Member

Right now we use type annotations but don't use any static analysis tools to check that the code is type-correct. We should look at using mypy or some other tool for this.
@norabelrose norabelrose added enhancement New feature or request good first issue Good for newcomers labels Feb 15, 2023
@norabelrose norabelrose added this to the PyPI 0.2 Release milestone Feb 15, 2023
@reaganjlee reaganjlee self-assigned this Feb 20, 2023
@thejaminator
Copy link
Collaborator

@norabelrose Do you still need this? Given that pyright was added in #90

@thejaminator thejaminator mentioned this issue Feb 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reaganjlee reaganjlee

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
PyPI 0.2 Release
Development

Successfully merging a pull request may close this issue.

Add mypy, fix types for mypy thejaminator/elk
3 participants
@thejaminator @norabelrose @reaganjlee